Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jest-haste-map on vagrant. #984

Closed
wants to merge 1 commit into from
Closed

Fix jest-haste-map on vagrant. #984

wants to merge 1 commit into from

Conversation

cpojer
Copy link
Member

@cpojer cpojer commented May 9, 2016

This is a similar fix to what @spicyj did in sophiebits@cff1410 a long time ago. I wasn't aware of why we had this but it seems obvious to me that we shouldn't create processes if there are less than one worker available. Not really sure how that could happen but it seems that on vagrant/docker installs the number of cores is 0.

See #980.

@ghost ghost added the CLA Signed ✔️ label May 9, 2016
@cpojer
Copy link
Member Author

cpojer commented May 9, 2016

@facebook-github-bot import

@ghost
Copy link

ghost commented May 9, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review.

@zpao
Copy link
Contributor

zpao commented May 9, 2016

Any chance this is the same fix needed to make coverage and runInBand work together?

@cpojer
Copy link
Member Author

cpojer commented May 9, 2016

Probably not, looks like a different bug unfortunately :(

@cpojer
Copy link
Member Author

cpojer commented May 9, 2016

We really need to start using flow + add more integration tests.

@ghost ghost closed this in 8797ecb May 10, 2016
@janaz
Copy link

janaz commented May 10, 2016

I think the proper fix should be around here (assuming that options.maxWorkers should represent the number of cores)
https://github.com/facebook/jest/blob/master/packages/jest-cli/src/jest.js#L41-L42

In the highlighted lines the options.maxWorkers is set to 0 for when cpus equals 1

@StephanBijzitter
Copy link
Contributor

I can confirm this PR fixes my issue.

@cpojer cpojer mentioned this pull request May 12, 2016
Closed
This was referenced Mar 28, 2021
Open
Open
Open
Open
Open
Open
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed ✔️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cpojer @zpao @janaz @StephanBijzitter